Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Feature: beta account activity #1006

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Conversation

@luixo luixo self-assigned this May 20, 2022
@luixo luixo requested a review from shelegdmitriy as a code owner May 20, 2022 12:02
@luixo luixo changed the base branch from feature/beta-account-activity to master May 20, 2022 13:55
@frol frol closed this May 20, 2022
@frol frol reopened this May 20, 2022
@luixo luixo deployed to feature/beta-account-activity-test1 - backend/testnet PR #1006 May 20, 2022 14:02 — with Render Active
@luixo luixo deployed to feature/beta-account-activity-test1 - backend/mainnet PR #1006 May 20, 2022 14:02 — with Render Active
@luixo luixo deployed to feature/beta-account-activity-test1 - backend/guildnet PR #1006 May 20, 2022 14:02 — with Render Active
@luixo luixo deployed to feature/beta-account-activity-test1 - backend/mainnet PR #1006 May 23, 2022 17:42 — with Render Active
@luixo luixo deployed to feature/beta-account-activity-test1 - backend/mainnet PR #1006 May 23, 2022 17:45 — with Render Active
@luixo luixo temporarily deployed to feature/beta-account-activity-test1 - frontend PR #1006 May 23, 2022 17:50 — with Render Destroyed
@luixo luixo force-pushed the feature/beta-account-activity-test1 branch from 783f516 to 2011f51 Compare May 25, 2022 12:14
@luixo luixo deployed to feature/beta-account-activity-test1 - backend/mainnet PR #1006 May 25, 2022 12:14 — with Render Active
@luixo luixo deployed to feature/beta-account-activity-test1 - backend/guildnet PR #1006 May 25, 2022 12:14 — with Render Active
@luixo luixo deployed to feature/beta-account-activity-test1 - backend/testnet PR #1006 May 25, 2022 12:14 — with Render Active
@luixo luixo force-pushed the feature/beta-account-activity-test1 branch from 2011f51 to c9abbfe Compare May 25, 2022 12:40
@luixo luixo deployed to feature/beta-account-activity-test1 - backend/mainnet PR #1006 May 25, 2022 12:40 — with Render Active
@luixo luixo deployed to feature/beta-account-activity-test1 - backend/guildnet PR #1006 May 25, 2022 12:40 — with Render Active
@luixo luixo deployed to feature/beta-account-activity-test1 - backend/testnet PR #1006 May 25, 2022 12:40 — with Render Active
@luixo luixo force-pushed the feature/beta-account-activity-test1 branch from c9abbfe to b164676 Compare May 25, 2022 14:42
@luixo luixo deployed to feature/beta-account-activity-test1 - backend/mainnet PR #1006 May 25, 2022 14:42 — with Render Active
@luixo luixo deployed to feature/beta-account-activity-test1 - backend/guildnet PR #1006 May 25, 2022 14:42 — with Render Active
@luixo luixo force-pushed the feature/beta-account-activity-test1 branch from 87da00b to 48e7cd7 Compare July 19, 2022 13:25
restake: {
backgroundColor: "#EEFDFE",
},
"validator-reward": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you don't use camelCase here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. I changed that to camelCase.


return (
<>
{actions.map((subaction, subindex) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

Suggested change
{actions.map((subaction, subindex) => {
{actions.map((subAction, subIndex) => {

Way more readable I guess.

</TableElement>
<DateTableElement>
{subindex === 0
? moment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don’t need moment here as we switched to another library

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I found as well after rebase :)

@github-actions
Copy link

github-actions bot commented Jul 22, 2022

Bundle size diff

Type Old size New size Diff
Client 2.56 MB 2.58 MB 19.6 KB (0.75%)
Server 345.52 KB 351.37 KB 5.85 KB (1.69%)

@luixo luixo force-pushed the feature/beta-account-activity-test1 branch from 71ad7f0 to 6defd21 Compare July 22, 2022 12:43
@luixo luixo temporarily deployed to feature/beta-account-activity-test1 - backend/guildnet PR #1006 July 22, 2022 12:43 — with Render Destroyed
@luixo luixo temporarily deployed to feature/beta-account-activity-test1 - backend/testnet PR #1006 July 22, 2022 12:43 — with Render Destroyed
@luixo luixo temporarily deployed to feature/beta-account-activity-test1 - backend/mainnet PR #1006 July 22, 2022 12:43 — with Render Destroyed
@luixo luixo temporarily deployed to feature/beta-account-activity-test1 - frontend PR #1006 July 22, 2022 12:43 — with Render Destroyed
@luixo luixo temporarily deployed to feature/beta-account-activity-test1 - backend/shardnet PR #1006 July 22, 2022 12:43 — with Render Destroyed
@luixo luixo merged commit 9401baa into master Jul 22, 2022
@luixo luixo deleted the feature/beta-account-activity-test1 branch July 22, 2022 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants