Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bounty] Add isValidAccountId function #199

Closed
willemneal opened this issue Aug 3, 2020 · 2 comments
Closed

[Bounty] Add isValidAccountId function #199

willemneal opened this issue Aug 3, 2020 · 2 comments
Labels
Bounty Open GitCoin Bounty

Comments

@willemneal
Copy link
Contributor

When dealing with account identifiers (accountId's) in smart contracts it is important that they can be validated.

API

//   This method is a simple string validation of accountId's.
function isValidAccountID(accountId: string): boolean

Implementation

Place the function in the env namespace.

Here is the rust implementation for guide.

Testing

Add tests here.

@willemneal willemneal added the Bounty Open GitCoin Bounty label Aug 3, 2020
@gitcoinbot
Copy link

gitcoinbot commented Aug 4, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 266 years, 3 months from now.
Please review their action plans below:

1) luciotato has been approved to start work.

I plan to translate rust to ts and then write 4 test assertions
2) nightwolf3 has applied to start work (Funders only: approve worker | reject worker).

I think I'm up for the task, already have experience in TS but reading the Rust implementation might take some time
3) vbstreetz has applied to start work (Funders only: approve worker | reject worker).

Had a go at https://bit.ly/2BYohDN and, was expecting https://bit.ly/2BYohDN to work but getting https://imgur.com/a/aLg2DXx error. Isn't near-sdk-as just a binding to near-sdk-rs?

Learn more on the Gitcoin Issue Details page.

@willemneal willemneal linked a pull request Aug 4, 2020 that will close this issue
2 tasks
@luciotato
Copy link
Contributor

I've added the function as requested
#203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty Open GitCoin Bounty
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants