Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added function isValidAccountID(accountId: string): boolean #203

Merged
merged 7 commits into from
Aug 6, 2020
Merged

added function isValidAccountID(accountId: string): boolean #203

merged 7 commits into from
Aug 6, 2020

Conversation

luciotato
Copy link
Contributor

@luciotato luciotato mentioned this pull request Aug 4, 2020
Closed
willemneal
willemneal suggested changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@willemneal willemneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small requests that you can batch and commit. You don't need to provide the type when it can be inferred.

assembly/sdk/env/env.ts Outdated Show resolved Hide resolved
assembly/sdk/env/env.ts Outdated Show resolved Hide resolved
assembly/sdk/env/env.ts Outdated Show resolved Hide resolved
@willemneal willemneal mentioned this pull request Aug 4, 2020
Closed
2 tasks
@luciotato luciotato requested a review from willemneal August 5, 2020 01:39
@willemneal
Copy link
Contributor

Great job!

@willemneal willemneal merged commit aa02eb3 into near:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willemneal willemneal willemneal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luciotato @willemneal