[2.0.0] feat: LookupMap and LookupSet #217
Conversation
evgenykuzyakov
requested review from
MaksymZavershynskyi,
mikedotexe and
willemneal
evgenykuzyakov
changed the title
|
Are we making this a minor version update? Seems like one could argue it's a major version update due to backwards-incompatible changes |
Good point. But it's also somewhat backward compatible, assuming these are deprecations. Like |
There was a problem hiding this comment.
Looks good overall. @chefsale this PR contains breaking changes, how do we pipe them into https://github.com/nearprotocol/near-ops/issues/123 ?
|
Going to change version to |
| { | ||
| fn default() -> Self { | ||
| Self::new(next_trie_id()) | ||
| Self { id, key, lft: None, rgt: None, ht: 1 } |
There was a problem hiding this comment.
Maybe left, right and height would be more readable?
There was a problem hiding this comment.
Yep. Bad naming.
evgenykuzyakov
changed the title
1.1.0Contract changes
status-message-collectionsto useLookupMapfungible-tokenimplementation to useLookupMap. It changes storage layout.API changes
LookupMapandLookupSetthat are faster implementations ofUnorderedMapandUnorderedSet, but without support for iterators.Most read/lookup/write are done in 1 storage access instead of 2 or 3 for
Unordered*implementations.Defaultis removed fromnear_sdk::collectionsto avoid implicit state conflicts.Collections should be initialized by explicitly specifying prefix using
newmethod.TreeMapimplementation was updated to useLookupMap.Previous
TreeMapimplementation was renamed toLegacyTreeMapand was deprecated.It should only be used if the contract was already deployed and state has to be compatible with the previous implementation.