Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ABI embedding #893
ABI embedding #893
Changes from all commits
476ba43
fca3a04
5954374
4baa8bb
f0e38f8
7404cb1
b833048
c9193de
d67e591
6cdbd3f
6628015
c521ee6
0f85589
1ddcbc8
ec2b378
c9d7c80
9670596
4720b28
f08954c
298e48a
794c491
2b3a8a0
6eb3ead
1d0f9b3
49d521c
52c6158
2a6db19
06129d4
e759423
20570b4
c0ddc89
01985b8
ff45f49
2e28d57
6e1adcf
4f7b6ba
bc7b0e7
e3d8378
2a442be
3e55eac
5054d11
9a91441
dec7029
97a0d01
b75d88d
1f9a7b2
03bab8d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but just noting that this would technically be a breaking change. Probably not big enough deal to warrant going into 5.x though.