chore(tests): replace tap with node:test #286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
|
Looks like node 16 doesn't have those testing flags. |
No, and we can drop Node < 20, and add 22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests themselves should be good, but I am not sure about the other files around them. I see previously there was a
testandtest:ciwith different reporters that would create their respective results in acoveragedirectory but the results are not being used anywhere.If they do need to still be around then we may have to wait until node:test has parity with tap or use custom reporters. Something I noticed for example is that node would fail to save the coverage files if they were supposed to be in a directory, due to typical
fs.writeFilebehavior that expects the path up to the file to already exist.