Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement : Moved Docker images repo to docker folder in main branch #2932

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Helion55
Copy link

@Helion55 Helion55 commented Feb 1, 2025

Reference Issues or PRs

Fixes #2871

What does this implement/fix?

  • Other (please describe):

Moved docker-images repo back to main nebari's repo. Changes made,

  1. Created folder named docker and moved the necessary files from docker repository.
  2. Updated the .github/workflows folder by adding the build-push-docker.yaml and test-images.yaml files from docker repo's workflow folder.
  3. Added documentation.yml and RFD.md files to .github/ISSUE_TEMPLATE folder.
  4. Updated .pre-commit-config.yaml file.

Testing

  • Did you add new tests?
    no

  • Did you test the pull request locally?
    no

Any other comments?

no

@viniciusdc
Copy link
Contributor

Hey @Helion55 thanks for opening this PR! we will have a look during the following days, in nebari we use pre-commit to lint the files and commit changes; its just a few typos, but if you want then to be self-fixed, you can pip install pre-commit and run pre-commit install that should then run in your next commit. For now, this is the line that currently needs changes:

error: `statis` should be `stasis`, `status`
  --> docker/scripts/install-conda-environment.sh:56:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New 🚦
Development

Successfully merging this pull request may close these issues.

[MAINT] - Move docker-images repo back to main nebari's repo
2 participants