support KubeSpawner profile_options #2937
Open
+44
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Kubespawner has support to configure various docker images (or other options) per profile. See
profile_options
in their docs. We didn't support it in our Pydantic models so this adds support. I tested it and it worked on my local deployment.I made a companion docs PR as well
What does this implement/fix?
Put a
x
in the boxes that applyTesting
How to test this PR?
Add this section to a nebari config.
then ensure the profile selection page looks something like
![image](https://private-user-images.githubusercontent.com/23342526/409835376-c6170013-bbeb-49de-a305-0536ac816948.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNDk2MDEsIm5iZiI6MTczOTI0OTMwMSwicGF0aCI6Ii8yMzM0MjUyNi80MDk4MzUzNzYtYzYxNzAwMTMtYmJlYi00OWRlLWEzMDUtMDUzNmFjODE2OTQ4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA0NDgyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUwMDViNjk3ZWUwNTI2MzE4YWMyMzI3YmI1NTIzYWRmMmE2OTIzYTYwMjVlYzA0NzBlNzBmMzZkNGE5OWE4NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.r5PEWwvyJI3b6CVzgcn9YOO_TmQHiyjd6oJ8HSsl_5Q)
It works whether or not jhub_apps is enabled.
Any other comments?