Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Playwright CI errors & update local instructions #2943

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Feb 6, 2025

Reference Issues or PRs

close #2933

What does this implement/fix?

  • Update readme notes for running the playwright tests locally;
  • Fix issue with pytest x playwright async/sync conflicts by using pytest-xdist
  • Include Makefile for easier setup
  • Fix conda-store issues with extension after recent upgrade
  • Add debug instructions

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @viniciusdc !

@viniciusdc viniciusdc merged commit 7e757c5 into main Feb 6, 2025
25 checks passed
@viniciusdc viniciusdc deleted the fix-playwright-tests branch February 6, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - Running playwright tests locally gives
3 participants