Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the release workflow #321

Merged
merged 2 commits into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 12 additions & 17 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,12 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Check out Git repository
uses: actions/checkout@v3
uses: actions/checkout@v2

- name: Install Java and Maven
uses: actions/setup-java@v1
with:
java-version: 1.8

- name: Install nebula-graph
run: |
Expand All @@ -24,20 +29,10 @@ jobs:
popd
popd

- name: Setup Java and Apache Maven Central
uses: actions/setup-java@v3
- name: Deploy Snapshot to Maven package
uses: samuelmeuli/action-maven-publish@v1
with:
java-version: '8'
distribution: 'temurin'
gpg-private-key: ${{ secrets.GPG_SECRET }} # Import GPG key
gpg-passphrase: ${{ secrets.GPG_PASSWORD }} # GPG passphrase
server-id: ossrh # Server ID for Maven Central
server-username: MAVEN_USERNAME # Environment variable for Maven username
server-password: MAVEN_PASSWORD # Environment variable for Maven password

- name: Publish package
run: mvn --batch-mode -e deploy
env:
MAVEN_USERNAME: ${{ secrets.OSSRH_USER }}
MAVEN_PASSWORD: ${{ secrets.OSSRH_PASSWORD }}
MAVEN_GPG_PASSPHRASE: ${{ secrets.GPG_PASSWORD }}
gpg_private_key: ${{ secrets.GPG_SECRET }}
gpg_passphrase: ${{ secrets.GPG_PASSWORD }}
nexus_username: ${{ secrets.OSSRH_USER }}
nexus_password: ${{ secrets.OSSRH_PASSWORD }}
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ This source code is licensed under Apache 2.0 License.
> http2 属于企业版的数据库才支持,但我没有测试环境,所以不确定是否可用。
> http2 is supported by the enterprise version of the database, but I don't have a test environment, so I'm not sure if it works.
- feat: support adding ID attributes of start and end nodes in edge entities.
> 通过 @DstId, @SrcId 进行注解,可以将属性标记成特殊的属性,用于查询时可以填充的起始点和终点的id值。
> 通过 `@DstId`, `@SrcId` 进行注解,可以将属性标记成特殊的属性,用于查询时可以填充的起始点和终点的id值。

- example:

Expand All @@ -78,8 +78,8 @@ This source code is licensed under Apache 2.0 License.
Route-Tag: abc
```

- feat: @Space annotation supports dynamic configuration.
> @Space 注解的 name 属性值可通过 spring 配置文件自定义配置。
- feat: `@Space` annotation supports dynamic configuration.
> `@Space` 注解的 name 属性值可通过 spring 配置文件自定义配置。
- example:

```yaml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ private void setClassModelBySpaceAnnotation(ClassModel cm) {
}
String spaceClassName = genericTypes[0].getTypeName();
Space annotation = Class.forName(spaceClassName).getAnnotation(Space.class);
if(null != annotation){
if (null != annotation) {
String spaceName = tryResolvePlaceholder(annotation.name());
if (!spaceName.equals("")) {
cm.setSpace(spaceName);
Expand All @@ -172,13 +172,15 @@ private void setClassModelBySpaceAnnotation(ClassModel cm) {
* @return resolveResult 解析结果
* @throws IllegalArgumentException 当配置了 ${xx.xx} 占位符,且spring配置文件中未指定该配置时抛出
*/
private String tryResolvePlaceholder(String value){
private String tryResolvePlaceholder(String value) {
String resolveResult = value;
if (null != applicationContext) {
try {
resolveResult = applicationContext.getEnvironment().resolveRequiredPlaceholders(value);
} catch (IllegalArgumentException e) {
throw new ResourceLoadException("name ( "+ value +" ) of @Space missing configurable value");
throw new ResourceLoadException(
"name ( " + value + " ) of @Space missing configurable value"
);
}
}
return resolveResult;
Expand Down
Loading