Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text: onLongPress feature #1235

Closed
wants to merge 0 commits into from

Conversation

DaKaZ
Copy link

@DaKaZ DaKaZ commented Jan 26, 2019

In an effort to close issue #1011 I implemented an onLongPress handler for text elements

@necolas
Copy link
Owner

necolas commented Jan 26, 2019

Thanks but the implementation should draw from React Native and integrate with the event system (see here), so this PR is not a suitable implementation

@DaKaZ
Copy link
Author

DaKaZ commented Jan 26, 2019

Thanks for the quick feedback. I’m sorry I don’t follow your direction though. Could you provide me a little more direction on what you’re looking for and I’ll do my best to update the PR

@DaKaZ DaKaZ closed this Mar 4, 2019
@DaKaZ DaKaZ force-pushed the 1011_text_long_press_support branch from ac9436d to 000b92e Compare March 4, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants