-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-o option no longer works with relative paths #14
Comments
Original comment by Geoff Bache (Bitbucket: geoffbache, GitHub: Unknown) Posted a simple fix (output of "hg bundle", hope this is OK) that essentially removes the code that converts all omit arguments to absolute paths (and adds a unit test for it). After all, source code files are referred by relative path name at this point if possible anyway, so converting to absolute paths only has the affect of making these references not work as far as I can see. If they were absolute to start with it will of course have no effect. |
Original comment by rozza (Bitbucket: rozza, GitHub: rozza) It would be nice if you could override the factory in an easy manner - as I like the regex style omission of files (similar to figleaf) - and in the end I had to overwrote the code_unit_factory:
It would be nice to have some way of hooking or extending this cleanly. |
The relative module problem is fixed in <<changeset 24db72e45ad8 (bb)>>. I moved the regex request to <<issue 36>>. |
Removing version: 3.0.1 (automated comment) |
Originally reported by Geoff Bache (Bitbucket: geoffbache, GitHub: Unknown)
In coverage 2.* it always used to work to just write
coverage -o , even though the documentation said "-o" was for absolute path prefixes. I found this ability fairly useful as I have third-party code inside my source tree. Would it be possible to restore this functionality?
(I have a patch for this which I will attach shortly)
The text was updated successfully, but these errors were encountered: