-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analysis fail on unicode characters on pyproject.toml ON WINDOWS only #990
Comments
staticdev
changed the title
Fail on unicode characters on pyproject.toml ON WINDOWS only
Analysis fail on unicode characters on pyproject.toml ON WINDOWS only
May 22, 2020
nedbat
added a commit
that referenced
this issue
May 23, 2020
nedbat
added a commit
that referenced
this issue
May 23, 2020
Thanks, this is fixed in 2cee76e. |
Very nice @nedbat, I will try as soon as there is a new release ^_^x thank a lot for being so effective! |
@nedbat is there any expected release for coveragepy for me to test this? |
This is now released as part of coverage 5.2. |
Thanks! Testing it today =) |
It works! Thanks a lot @nedbat. |
This was referenced Jul 6, 2020
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If you add coverage with toml extra and have unicode characters on your pyproject.toml you get enconding error on coverage analysis on Windows only.
To Reproduce
How can we reproduce the problem?
What code are you running?
See Github actions output from this pull request: Windows staticdev/toml-validator#51
What commands did you run?
coverage run --parallel -m pytest
Please note that if you change the author name that has the character Á in Ávila from pyproject.toml, the error goes away!
Expected behavior
No error at all.
Additional context
Another package that had exactly the same issue has the following fix: https://github.com/pre-commit/pre-commit-hooks/pull/479/files
The text was updated successfully, but these errors were encountered: