CoverageSqliteData._file_id: use "insert or replace" #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anarcat
reviewed
Oct 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 78 78
Lines 10884 10884
Branches 1127 1127
=======================================
Hits 9822 9822
Misses 939 939
Partials 123 123
Continue to review full report at Codecov.
|
blueyed
changed the title
nedbat
reviewed
Apr 2, 2019
| If `add` is not True, return None. | ||
| """ | ||
| if filename not in self._file_map: | ||
| if add: | ||
| with self._connect() as con: | ||
| cur = con.execute("insert into file (path) values (?)", (filename,)) | ||
| cur = con.execute("insert or replace into file (path) values (?)", (filename,)) |
There was a problem hiding this comment.
You've made the link.. I guess it can help, but can only say it for #702 (comment) really, although I've not tested the "insert or replace" attempt with that one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #702