Allow for stdout to return the data in chunks #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data piped in from wmic command is not guaranteed to come in line by line, but the exit function that finds the `beginRow` expects each line to be on its own. This fix splits the data as it comes in to fix this bug.
neekey
added a commit
that referenced
this pull request
Sep 20, 2015
Allow for stdout to return the data in chunks
|
published in 0.0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I ran any ps-node command on windows it was failing with a
undefined is not a functionbecause output from the command list empty.Tracked it down to the fact that the data piped in from wmic command is not guaranteed to come in line by line, but the exit function that finds the
beginRowexpects each line to be on its own. This fix splits the data as it comes in to fix this bug.