Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that only one Vulkan ICD manifest is present. #96

Merged

Conversation

jp7677
Copy link
Contributor

@jp7677 jp7677 commented Feb 14, 2020

Install a single nvidia_icd.json file, regardless the target
architecture, to prevent having two ICD manifests present
when both x64 and i686 driver libraries are installed.
Having multiple Vulkan ICD manifest installed tricks the Vulkan
loader into thinking that there are two adapters installed.

Fixes #95

@jp7677
Copy link
Contributor Author

jp7677 commented Feb 14, 2020

This is an attempt to fix #95
Note that I created this PR just based on looking at the spec file. I haven't actually build a package.

I wasn't sure if I should surround the loader block with a %ifarch x86_64 like you did for the Vulkan layer manifest file. I could image that leaving this out might create a conflict between the x64 and i686 packages. Please let me what the correct way is.

Install a single nvidia_icd.json file, only for x64,
to prevent having two ICD manifests present when
both x64 and i686 driver libraries are installed.
Having multiple Vulkan ICD manifest installed tricks
the Vulkan loader into thinking that two adapters are
installed.

Fixes negativo17#95
@jp7677 jp7677 force-pushed the ensure-single-vulkan-icd-manifest branch from 9602920 to d87f724 Compare February 14, 2020 11:09
@scaronni scaronni merged commit c78dbe4 into negativo17:master Feb 15, 2020
@scaronni
Copy link
Member

Thank you! Rebuilding packages now.

@jp7677
Copy link
Contributor Author

jp7677 commented Feb 17, 2020

Thanks a lot for the fast response! Glad to hear that the PR seemed correct. How long should it take until the rebuilt packages appear at https://negativo17.org/repos/?

@leigh123linux
Copy link

@jp7677
Copy link
Contributor Author

jp7677 commented Feb 17, 2020

@leigh123linux ah, thanks a lot for the hint. I'll create a second PR today after work which hopefully fixes this.

@scaronni
Copy link
Member

@jp7677 no need to update the PR, i fixed it in a subsequent commit the other day when i merged the PR: 3b5969f

@scaronni
Copy link
Member

Thanks a lot for the fast response! Glad to hear that the PR seemed correct. How long should it take until the rebuilt packages appear at https://negativo17.org/repos/?

Pushing them now. Sorry i was a bit busy.

@jp7677
Copy link
Contributor Author

jp7677 commented Feb 17, 2020

@jp7677 no need to update the PR, i fixed it in a subsequent commit the other day when i merged the PR: 3b5969f

Thanks a lot and sorry for not seeing it in the first place.

@jp7677
Copy link
Contributor Author

jp7677 commented Feb 17, 2020

Just updated my machine and all is good now, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulkan detects two GPU's with both x64 and i686 driver being installed
3 participants