Fix/export and polytomies #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- very rapid coalescent rates were silently ignored, TreeTime now raises an error and exits - date and genotype annotations in auspice json were flipped - auspice json now contains data and the treetime version
- slightly changed grid for merger model during propagation - typos & comments - set default coloring in output
- add `--rng-seed` to all subcommands - use this seed to initialize the default RNG of numpy - use this RNG for all random number generation (replace previous scipy.stats call with numpy calls)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main part of this PR is a reorganization of how random number generator states are handled in TreeTime.
This was previously scattered around and used the default numpy or scipy states. Now, the class TreeAnc owns its own RNG instance that can be seeded explicitly in the constructor and the command line.
Otherwise, this PR implements a few fixes and clean ups