Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip messages for queue #10088

Closed
marleighnorton opened this issue Jan 18, 2025 · 3 comments · Fixed by #10119
Closed

Skip messages for queue #10088

marleighnorton opened this issue Jan 18, 2025 · 3 comments · Fixed by #10119
Assignees

Comments

@marleighnorton
Copy link

marleighnorton commented Jan 18, 2025

Since @nbudin is working on this feature next-ish, figured it'd be worth going through the cases where a game in a queue would be skipped and what the messages would be. In order of checks:

Skip: You are already signed up
Skip: You are already on the waitlist
Skip: Conflicts with [conflicting event]
Skip: You set a limit for signups on [DAY], and that limit has been reached
Skip: You set a limit for total signups , and that limit has been reached

Not loving the "You are" language for the first two, but not coming up with better phrasing that isn't totally stilted.

@nbudin nbudin added this to Intercode Jan 18, 2025
@nbudin nbudin self-assigned this Jan 18, 2025
@nbudin nbudin moved this from Todo to Next in Intercode Jan 18, 2025
@marleighnorton
Copy link
Author

@vogon999

@nbudin
Copy link
Contributor

nbudin commented Jan 22, 2025

@marleighnorton Got one more case for you:

Skip: {{ eventTitle }} is full, and you have opted not to be put on waitlists

Is that wording ok?

@nbudin nbudin moved this from Next to In Progress in Intercode Jan 22, 2025
nbudin added a commit that referenced this issue Jan 22, 2025
@marleighnorton
Copy link
Author

I'm a little hesitant about that particular case, since a game being full can change suddenly. But if we want to cover that case, the wording is fine with me.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Intercode Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants