Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #117 - handle whitespace in actrc secrets #118

Merged
merged 3 commits into from
Mar 2, 2020
Merged

fix #117 - handle whitespace in actrc secrets #118

merged 3 commits into from
Mar 2, 2020

Conversation

Steffen911
Copy link
Contributor

Fixes #117

Currently whitespaces in secrets provided via .actrc lead to problems, because strings.Fields splits on all spaces. Now, only the first space is used for splitting. Same for = in the secret handling method.

@Steffen911 Steffen911 requested a review from cplee as a code owner March 2, 2020 11:54
Copy link
Contributor

@cplee cplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cplee cplee merged commit 4f84be1 into nektos:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Longer secret string throws error
2 participants