allow more control of filtering Reply errors #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Reply.Err()
andRPCErrors.Filter()
are useful functions to get theSevError
level errors out, but some people may want to treatSevWarning
as errors as well and doing it manually is a pain.As not to add a bunch of alternative functions like
RPCError.FilterWarn
,Reply.ErrWarn()
andReply.ErrAll()
this updatesFilter
andErr
to take in a list of desired severity levels. If they are missing they go back to defaulting toSevError
which is a sane default.Breaking change:
The API for
reply.Err()
andRPCErrors.Filter()
were changed as above. For most call sites this should be fine but anyone using this function in a interface or explicitly using it as a type will break.ErrSevError
was renamed toSevError
ErrSevWarning
was reanmed toSevWarning
As the API is not yet stable these changes are ok and will become stabilized after 1.0.0