"_jit_pass_onnx_function_substitution" was added in PT 1.6 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass was added after PyTorch 1.5.1
vdantu
changed the title
lekk32
approved these changes
Dec 1, 2020
kkoppolu1
reviewed
Dec 1, 2020
| @@ -2714,7 +2714,7 @@ def _run_jit_passes(graph): | |||
| """ The inline pass is necessary to unwrap prim::CallMethod """ | |||
| import torch | |||
|
|
|||
| if _is_version_greater_than("1.5.0"): | |||
| if _is_version_greater_than("1.5.1"): | |||
There was a problem hiding this comment.
This fix will not work if the version string is of the form "1.5.1+cpu" or the like. The method _is_version_greater_than will return "1.5.1+cpu" is greater than "1.5.1" since that is what packaging.version.parse returns
|
Closing since #181 has the same change from upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix to pytorch parser. "_jit_pass_onnx_function_substitution" pass was added after PyTorch 1.5.1
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.