Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Added AspNetCore (#863)" #864

Closed
wants to merge 1 commit into from
Closed

Conversation

vncoelho
Copy link
Member

@vncoelho vncoelho commented Jan 7, 2024

This reverts commit e9e7a07.

if neo-project/neo#3066 is merged

Copy link
Member

@cschuchardt88 cschuchardt88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be done. PR neo-project/neo#3067 fixes issue.

@vncoelho
Copy link
Member Author

vncoelho commented Jan 7, 2024

I do not think, so @cschuchardt88
I tried here and there are compilations problems without that change.

@vncoelho vncoelho closed this Jan 7, 2024
@vncoelho vncoelho deleted the revertAspNetOnRpc branch January 7, 2024 23:36
@cschuchardt88
Copy link
Member

NVM close this.

This still needs to be done, Because no neo.dll that imports asp.net framework.

@vncoelho vncoelho restored the revertAspNetOnRpc branch January 9, 2024 00:49
@vncoelho
Copy link
Member Author

vncoelho commented Jan 9, 2024

@shargon, too much instability on that other change. I am still not feeling safe to go.

The changes are requesting too much for the basic environment to build and run a simple client.

@vncoelho vncoelho reopened this Jan 9, 2024
@cschuchardt88
Copy link
Member

Let me fix RestServer 1st, and problem gone.

@vncoelho
Copy link
Member Author

vncoelho commented Jan 9, 2024

I am not in hurry, most of the current working PRs are made by you @cschuchardt88 ....aheuaheuahea
As soon as everything is clear it will look good to me.
But fell free to move on if you guys fell it is good.

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jan 9, 2024

It's just user error on your part. I tested everything with and without docker.

Please close. If need a dockerfile i can help you with that its very easy.

image

@vncoelho vncoelho closed this Jan 9, 2024
@vncoelho vncoelho deleted the revertAspNetOnRpc branch January 9, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants