Clean p2p plugin #2216
Merged
Clean p2p plugin #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why? |
|
But it could be used in other plugins. If we remove it, plugins have to reverify the inventories. |
If they use the same mechanism they won't need to verify the inventories, only check the sender. I think that the logic should be the same. |
erikzhang
approved these changes
Jan 12, 2021
3 tasks
chenzhitong
added a commit
to chenzhitong/neo
that referenced
this pull request
Jan 13, 2021
Clean p2p plugin (neo-project#2216)
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to neo-project/neo-modules#453 (comment)