Update CalculateNetworkFee #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@dotnet-policy-service agree company="Belane" |
shargon
previously approved these changes
Sep 27, 2023
AnnaShaleva
reviewed
Sep 27, 2023
src/Neo/Wallets/Wallet.cs
Outdated
| @@ -596,6 +596,7 @@ public long CalculateNetworkFee(DataCache snapshot, Transaction tx) | |||
| uint exec_fee_factor = NativeContract.Policy.GetExecFeeFactor(snapshot); | |||
| long networkFee = 0; | |||
| int index = -1; | |||
| long gas_left = ApplicationEngine.TestModeGas; | |||
There was a problem hiding this comment.
Shouldn't it be settings.MaxGasInvoke for consistency with invoke* RPC calls? Or maybe the minimum of two values?
There was a problem hiding this comment.
OK, settings.MaxGasInvoke is unreachable from the Wallet class, so resolved.
There was a problem hiding this comment.
Likely this can be solved with some API extension, a bit more invasive though.
|
Likely a bit better this way: nspcc-dev/neo-go#3141 |
|
Sometimes need a re-sync is different than being affected by a future re-sync....Just to be sure...aehauhea |
shargon
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the calculation of gas used during the verification.