fixes #116: Connector Configuration (Sink) #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following an example:
|
jexp
reviewed
Jan 30, 2019
| neo4j.connection.acquisition.timeout.msecs=Type: Long;\nDescription: The max Neo4j acquisition timeout (default 1 hour) | ||
| neo4j.connection.liveness.check.timeout.msecs=Type: Long;\nDescription: The max Neo4j liveness check timeout (default 1 hour) | ||
| neo4j.connection.max.pool.size=Type: Int;\nDescription: The max pool size (default 100) | ||
| neo4j.load.balance.strategy=Type: enum[ROUND_ROBIN, LEAST_CONNECTED];\nDescription: The Neo4j load balance strategy (default LEAST_CONNECTED) |
There was a problem hiding this comment.
should the topics + queries have an entry here too?
There was a problem hiding this comment.
No because of these are only for the UI, as the UI needs fixed property keys (and we have neo4j.topic.cypher.<TOPIC>=<QUERY>), if we implement the #136 we can have a property here
jexp
reviewed
Jan 30, 2019
| # limitations under the License. | ||
| ## | ||
|
|
||
| neo4j.server.uri=Type: String;\nDescription: The Bolt URI |
There was a problem hiding this comment.
should we note a default URL (do we have one?)
|
but this doesn't fix/change the topics config? |
No, because for that we have the #136, but I keep it on hold because I'm waiting for Josh's feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116 (for the Sink)
Proposed Changes (Mandatory)
A brief list of proposed changes in order to fix the issue:
neo4j.batch.timeout.msecintoneo4j.batch.timeout.msecsin order to be compliant to the other similar properties (we need to manage the old version?)