This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upstream merge
Upstream merge
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
==========================================
+ Coverage 95.4% 96.25% +0.85%
==========================================
Files 10 23 +13
Lines 2350 2565 +215
==========================================
+ Hits 2242 2469 +227
+ Misses 108 96 -12
Continue to review full report at Codecov.
|
johnymontana
added a commit
that referenced
this pull request
Oct 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone!
This PR has been in the works for a while, and I've appreciated your patience. It almost entirely rewrites the augmentation process and is meant to only replicate current behavior. Still, as a result of new design, there are a few changes that might go noticed:
@relation
type directives are no longer generated (an undocumented behavior...), although default relationshipname
arguments still are.It is my hope that this design will enable a smoother development of various bug fixes and features that depend upon the augmentation process. I would love any feedback you might have! 🙂🚀