Cypher builder connections #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 90ee4b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
angrykoala
commented
Jul 18, 2022
angrykoala
force-pushed
the
cypher-builder-connections
branch
from
ecf2c87 to
eed8ba9
Compare
darrellwarde
previously approved these changes
Jul 20, 2022
packages/graphql/src/translate/where/property-operations/create-connection-operation.ts
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the connections where translation to cypher builder and removes one instance of runFirstColumn.
This PR depends on #1769
Fixes #1782
Fixes #1783
Slight improvement on performance for deeply nested connection filters