-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the 1756, add extra test for nested bug(callback not being invoked) #1842
Conversation
🦋 Changeset detectedLatest commit: 9270885 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of proposals in the code and tests
Thanks for the UI updates. The UI has now been torn down - reopening this PR will republish it. |
Co-authored-by: angrykoala <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just missing a changeset!!! 🙂
Oh no! I'll add it :) |
Description
Fix PR for the bug #1756, during the fix it was found that the callback fields where not getting resolved inside the onCreate statement.
Issue
Closes:
Checklist
The following requirements should have been met (depending on the changes in the branch):