Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the 1756, add extra test for nested bug(callback not being invoked) #1842

Merged
merged 6 commits into from
Aug 10, 2022

Conversation

MacondoExpress
Copy link
Contributor

@MacondoExpress MacondoExpress commented Aug 4, 2022

Description

Fix PR for the bug #1756, during the fix it was found that the callback fields where not getting resolved inside the onCreate statement.

Issue

Closes:

Checklist

The following requirements should have been met (depending on the changes in the branch):

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022

🦋 Changeset detected

Latest commit: 9270885

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@neo4j/graphql Patch
@neo4j/graphql-ogm Patch
@neo4j/graphql-toolbox Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

angrykoala
angrykoala previously approved these changes Aug 4, 2022
Copy link
Member

@angrykoala angrykoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of proposals in the code and tests

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Aug 4, 2022

Thanks for the UI updates.

The UI has now been torn down - reopening this PR will republish it.

@MacondoExpress MacondoExpress marked this pull request as ready for review August 9, 2022 11:33
Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just missing a changeset!!! 🙂

@MacondoExpress
Copy link
Contributor Author

Looks good, just missing a changeset!!! 🙂

Oh no! I'll add it :)

@MacondoExpress MacondoExpress merged commit 1149f7a into neo4j:dev Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connectOrCreate does not automatically generate properties that have a @callback directive
4 participants