Remove unique #5755
Merged
Remove unique #5755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ddcd886 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -80,9 +79,6 @@ export class ConcreteEntityAdapter { | |||
|
|
|||
| if (attributeAdapter.isConstrainable()) { | |||
| this.constrainableFieldsKeys.push(attribute.name); | |||
| if (attributeAdapter.isUnique()) { | |||
There was a problem hiding this comment.
I believe the whole logic could isConstrainable can be removed from both here and Interfaces, could you confirm this?
| @@ -112,10 +111,6 @@ export class InterfaceEntityAdapter { | |||
| * used to generate different types for the Entity that contains these Attributes | |||
| */ | |||
|
|
|||
| public get uniqueFields(): AttributeAdapter[] { | |||
| return this.uniqueFieldsKeys.map((key) => getFromMap(this.attributes, key)); | |||
There was a problem hiding this comment.
uniqueFieldsKeys attribute has to be removed as well
MacondoExpress
approved these changes
Nov 5, 2024
angrykoala
force-pushed
the
remove-unique
branch
from
47c86b7 to
ddcd886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
@uniquedirective and update testsSome code is still leftover from
connectOrCreate, which is implicitly removed by this PR