Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated options argument #5777

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

darrellwarde
Copy link
Contributor

@darrellwarde darrellwarde commented Nov 11, 2024

Description

The deprecated options argument has been removed.

Consider the following type definitions:

type Movie {
  title: String!
}

The migration is as below:

# Old syntax
{
  movies(options: { first: 10, offset: 10, sort: [{ title: ASC }] }) {
    title
  }
}

# New syntax
{
  movies(first: 10, offset: 10, sort: [{ title: ASC }]) {
    title
  }
}

Complexity

Complexity: Low

Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: 6b0793a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@neo4j/graphql Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@MacondoExpress MacondoExpress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unreachable code block, apart from that it looks good!

Copy link
Contributor

@MacondoExpress MacondoExpress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darrellwarde darrellwarde merged commit 0ecfd71 into neo4j:7.x Nov 13, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants