Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate summary error reporting on session closure in reactive #1015

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

injectives
Copy link
Contributor

@injectives injectives commented Sep 16, 2021

Reactive driver might emit the same error both on unconsumed result stream disposal and session closure, this update is intended to fix this.

@injectives injectives marked this pull request as draft September 16, 2021 20:03
@injectives injectives marked this pull request as ready for review September 16, 2021 21:36
@injectives injectives force-pushed the feature/reporting branch 2 times, most recently from 6da7f47 to 767f592 Compare September 16, 2021 22:47
@injectives injectives force-pushed the feature/reporting branch 3 times, most recently from cc70722 to dc3ebab Compare November 3, 2021 19:48
@injectives injectives changed the title Prevent reporting previous error on session closure Prevent duplicate summary error reporting on session closure in reactive Nov 3, 2021
Reactive driver might emit the same error both on unconsumed result stream disposal and session closure, this update is intended to fix this.
Copy link
Contributor

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreeing that a potential error should not necessary be propagated inside a CompletionStage<> (for future improvements).

@injectives injectives merged commit a44346c into neo4j:4.4 Nov 4, 2021
@injectives injectives deleted the feature/reporting branch November 4, 2021 11:32
injectives added a commit to injectives/neo4j-java-driver that referenced this pull request Nov 10, 2021
…ive (neo4j#1015)

Reactive driver might emit the same error both on unconsumed result stream disposal and session closure, this update is intended to fix this.
injectives added a commit to injectives/neo4j-java-driver that referenced this pull request Nov 10, 2021
…ive (neo4j#1015)

Reactive driver might emit the same error both on unconsumed result stream disposal and session closure, this update is intended to fix this.
injectives added a commit that referenced this pull request Nov 11, 2021
…ive (#1015) (#1067)

Reactive driver might emit the same error both on unconsumed result stream disposal and session closure, this update is intended to fix this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants