Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supported protocol versions to testkit backend #1056

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Add supported protocol versions to testkit backend #1056

merged 1 commit into from
Nov 3, 2021
+8 −15

Conversation

injectives
Copy link
Contributor

No description provided.

michael-simons
michael-simons approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nic with the feature flags.
Unrelated to that change: I usually make those constants set immutable just for safety.

@injectives
Copy link
Contributor Author

4.4 builds are currently failing on 4.4 branch, this has not been introduced by this update.

@injectives injectives merged commit 06c833c into neo4j:4.4 Nov 3, 2021
@injectives injectives deleted the feature/b branch November 3, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-simons michael-simons michael-simons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@injectives @michael-simons