Session acquisition update #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getServers` now only returns a single row containing all the information, together with a `ttl` that is no longer per server but a global `ttl` for the returned servers.
Whenever we go down to the database to call `getServers` we should use the values returned from the call and forget about any servers returned in previous calls.
pontusmelke
force-pushed
the
1.1-acquisition-fixup
branch
from
d01f054 to
b2ab2ed
Compare
The returned `ttl` from server is now respected. Whenever we do acquisition we check if the information is stale, if so we do new `getServers` call.
pontusmelke
force-pushed
the
1.1-acquisition-fixup
branch
from
b2ab2ed to
740db84
Compare
pontusmelke
force-pushed
the
1.1-acquisition-fixup
branch
from
2538c96 to
2a27bf2
Compare
Whenever we do rediscovery and the server forces us to discard all connections to endpoints no longer valid in the servers point-of-view, there is a chance there are still open connections to those endpoints and when closing these open sessions we must make sure we properly close these connections without putting them back to the connection pool.
pontusmelke
force-pushed
the
1.1-acquisition-fixup
branch
from
ec5a329 to
e9d44ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt the driver to server-side changes:
getServersnow returns a single row containing all the information.getServerswe should forget about any servers that is not in the return and update our view ofrouters,readers, andwritersttlcoming from the server. On acquisition we check if our knowledge is stale, if so ask the server to update our view of the cluster.Note that this PR assumes the response from
getServerslooks likewhere
ttlis measured in seconds.