Deprecated old routing retry settings #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deprecates `ConfigBuilder#withRoutingFailureLimit()` and `ConfigBuilder#withRoutingRetryDelay()` methods because they are now obsolete. They were initially introduced to postpone failure when no routers are available. Currently there exists a better way of doing this with transaction functions (`Session#readTransaction()` and `Session@writeTransaction()`). Driver also memorizes the seed URI and falls back to it during rediscovery when all other routers are dead.
|
Should this be merged to 1.2 or 1.3 branch? |
|
@zhenlineo changed the base branch to 1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates
ConfigBuilder#withRoutingFailureLimit()andConfigBuilder#withRoutingRetryDelay()methods because they are now obsolete. They were initially introduced to postpone failure when no routers are available. Currently there exists a better way of doing this with transaction functions (Session#readTransaction()andSession@writeTransaction()). Driver also memorizes the seed URI and falls back to it during rediscovery when all other routers are dead.