Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example code in Readme #1249

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Update example code in Readme #1249

merged 1 commit into from
Feb 5, 2025

Conversation

MaxAake
Copy link
Contributor

@MaxAake MaxAake commented Feb 5, 2025

Replaces deprecated function use and moves session.run usage examples down to not be the top example.

Additionally removes linter for the readme, as it's not useful.

Replaces deprecated function use, and moves session.run usage examples down to not be the top example.
Copy link

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have one question for going forward though. Should we move it away from session.Run to the tx functions? I'm generally wary of using session.run in examples, even with it being so simple. Open to thoughts.

@MaxAake MaxAake merged commit ae705f7 into 5.0 Feb 5, 2025
37 checks passed
@MaxAake MaxAake deleted the update-readme branch February 5, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants