Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls-name now simply as rls in nightly #4

Closed
oblitum opened this issue Dec 6, 2018 · 12 comments
Closed

rls-name now simply as rls in nightly #4

oblitum opened this issue Dec 6, 2018 · 12 comments

Comments

@oblitum
Copy link
Member

oblitum commented Dec 6, 2018

On my Rust installation now RLS is now simply named "rls", instead of "rls-preview". This cause coc-rls to fail a regex match because it defaults to match "rls-preview".

@oblitum
Copy link
Member Author

oblitum commented Dec 6, 2018

It can be fixed setting rust-client.rls-name, but still, I'm leaving issue open because I'm not sure what should be the default, maybe both?

@chemzqm
Copy link
Member

chemzqm commented Dec 7, 2018

Checkout rust-lang/rls#641

@oblitum
Copy link
Member Author

oblitum commented Dec 7, 2018

@chemzqm not sure what's there to help. I have RLS, it's just named rls locally, not rls-preview anymore.

@chemzqm
Copy link
Member

chemzqm commented Dec 7, 2018

You can disable rust-client and use rls command to start server.

@oblitum
Copy link
Member Author

oblitum commented Dec 7, 2018

Hi @chemzqm, it starts fine, I just need to set rust-client.rls-name to rls and all works. Another user that reported to have to set it here: neoclide/coc.nvim#235.

I'm not sure whether the RLS devs flipped and changed names from rls-preview to just rls lately. Hence I've left the issue open as suggestion on that.

@chemzqm
Copy link
Member

chemzqm commented Dec 7, 2018

Checkout rls's documentation: https://github.com/rust-lang/rls#note-nightly-only

@oblitum
Copy link
Member Author

oblitum commented Dec 7, 2018

But it is included, I'm using it, that's not the issue.... Anyway, closing.

@oblitum oblitum closed this as completed Dec 7, 2018
@oblitum
Copy link
Member Author

oblitum commented Dec 7, 2018

❯❯❯ rustup component add rls-preview rust-analysis rust-src
...
❯❯❯ rustup component list --toolchain nightly
cargo-x86_64-unknown-linux-gnu (default)
clippy-x86_64-unknown-linux-gnu
llvm-tools-preview-x86_64-unknown-linux-gnu
rls-x86_64-unknown-linux-gnu (installed)                   <<<<<<<< rls, not rls-preview as name anymore
rust-analysis-x86_64-unknown-linux-gnu (installed)
rust-docs-x86_64-unknown-linux-gnu (default)
rust-src (installed)
...

@oblitum
Copy link
Member Author

oblitum commented Dec 7, 2018

This is the recent discussion where renaming of RLS component from "rls-preview" to "rls" is mentioned:

@oblitum
Copy link
Member Author

oblitum commented Dec 7, 2018

It can already be installed with just rls:

rustup component add rls rust-analysis rust-src

The above works, which means "rls-preview" is being phased out. rustup component add rls-preview rust-analysis rust-src still works, but when installed the component will be named simply "rls".

@chemzqm
Copy link
Member

chemzqm commented Dec 7, 2018

It's fixed, just like rls-vscode did rust-lang/vscode-rust@037807f

@oblitum
Copy link
Member Author

oblitum commented Dec 7, 2018

@chemzqm OK. Looks like I needed to remove <project-dir>/target/rls/ (or just the whole <project-dir>/target/) from project directory for coc stop offering installation of RLS when it was already installed in the system. The <project-dir>/target/rls had cached reference to the previous rls-preview component, and that made coc look up for rls-preview instead of rls. After deleting that folder, coc was able to pick rls by default now. So there's this problem with those project caches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants