Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate descriptor set for Google well-known types #37

Merged
merged 2 commits into from
Nov 13, 2022
Merged

feat: generate descriptor set for Google well-known types #37

merged 2 commits into from
Nov 13, 2022

Conversation

neoeinstein
Copy link
Owner

Closes #4

cc: @hexfusion

hexfusion
hexfusion approved these changes Nov 13, 2022
View reviewed changes
Copy link

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thank you

protoc-wkt/README.md Show resolved Hide resolved
@neoeinstein
Copy link
Owner Author

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 13, 2022

Build succeeded:

@bors bors bot merged commit aa521eb into main Nov 13, 2022
@bors bors bot deleted the generate-descriptor-set-for-wkt branch November 13, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexfusion hexfusion hexfusion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reflection fails for compile_well_known_types
2 participants
@neoeinstein @hexfusion