Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in file_descriptor_set #46

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Fixed typo in file_descriptor_set #46

merged 1 commit into from
Jan 17, 2023

Conversation

maoueh
Copy link
Contributor

@maoueh maoueh commented Jan 11, 2023

This made usage of --prost_opt=…file_descriptor_set=false fail with an error

@maoueh
Fixed typo in file_descriptor_set, this made usage of `--prost_opt=…
26d4226 
…file_descriptor_set=false` fail with an error
neoeinstein
neoeinstein approved these changes Jan 17, 2023
View reviewed changes
Copy link
Owner

@neoeinstein neoeinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for catching this!

@neoeinstein
Copy link
Owner

bors +r

@bors
Copy link
Contributor

bors bot commented Jan 17, 2023

Did you mean "r+"?

@neoeinstein
Copy link
Owner

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 17, 2023

Build succeeded:

@bors bors bot merged commit 79b90ba into neoeinstein:main Jan 17, 2023
@maoueh maoueh deleted the fix/file_descriptor_set_typo branch January 24, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neoeinstein neoeinstein neoeinstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maoueh @neoeinstein