-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for prost remote plugins #69
Update documentation for prost remote plugins #69
Conversation
I noticed there is also a |
This can replace the work in #66 as the crate plugin is also now available. |
IMAGE=$2 | ||
VERSION=$(cargo read-manifest --manifest-path "protoc-gen-$PLUGIN/Cargo.toml" 2>/dev/null | jq -r .version) | ||
|
||
docker buildx build --platform=linux/amd64 --build-arg "BIN=protoc-gen-$PLUGIN" -t "plugins.buf.build/prost/$IMAGE:$VERSION-$ITER" --push . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI the plugins.buf.build
domain is going away with the alpha remote removal. This script will no longer be functional so it should be safe to remove.
@neoeinstein - I'm not sure if you're actively working on this project any more, but these changes would be good to land prior to July 10th - that's the date we're removing support for the prior alpha - see https://buf.build/docs/migration-guides/migrate-remote-generation-alpha/ for more details. |
Hey @pkwarren, Sorry for the delay; something seems to have black-holed my GitHub notifications, but I'm working on fixing that. I'm reviewing my backlog here now, and will get stuff prepared shortly. |
These plugins are now maintained and automatically updated by the buf team at https://github.com/bufbuild/plugins. Update the documentation to point to the new plugin locations and use the new syntax to invoke remote plugins, as the previous plugins alpha is deprecated and going away on July 10th.
These plugins are now maintained and automatically updated by the buf team at https://github.com/bufbuild/plugins. Update the documentation to point to the new plugin locations and use the new syntax to invoke remote plugins, as the previous plugins alpha is deprecated and going away on July 10th.