Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for prost remote plugins #69

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Update documentation for prost remote plugins #69

merged 2 commits into from
Jun 30, 2023

Conversation

pkwarren
Copy link
Contributor

These plugins are now maintained and automatically updated by the buf team at https://github.com/bufbuild/plugins. Update the documentation to point to the new plugin locations and use the new syntax to invoke remote plugins, as the previous plugins alpha is deprecated and going away on July 10th.

@pkwarren
Copy link
Contributor Author

I noticed there is also a publish_buf.sh which can be removed from this project (I don't see references to it any longer, but it won't work any more). Updates to plugins hosted by Buf on the BSR should be made upstream at https://github.com/bufbuild/plugins.

@pkwarren
Copy link
Contributor Author

This can replace the work in #66 as the crate plugin is also now available.

IMAGE=$2
VERSION=$(cargo read-manifest --manifest-path "protoc-gen-$PLUGIN/Cargo.toml" 2>/dev/null | jq -r .version)

docker buildx build --platform=linux/amd64 --build-arg "BIN=protoc-gen-$PLUGIN" -t "plugins.buf.build/prost/$IMAGE:$VERSION-$ITER" --push .
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI the plugins.buf.build domain is going away with the alpha remote removal. This script will no longer be functional so it should be safe to remove.

@pkwarren
Copy link
Contributor Author

@neoeinstein - I'm not sure if you're actively working on this project any more, but these changes would be good to land prior to July 10th - that's the date we're removing support for the prior alpha - see https://buf.build/docs/migration-guides/migrate-remote-generation-alpha/ for more details.

@neoeinstein
Copy link
Owner

Hey @pkwarren, Sorry for the delay; something seems to have black-holed my GitHub notifications, but I'm working on fixing that. I'm reviewing my backlog here now, and will get stuff prepared shortly.

pkwarren added 2 commits June 30, 2023 08:26
These plugins are now maintained and automatically updated by the buf
team at https://github.com/bufbuild/plugins. Update the documentation to
point to the new plugin locations and use the new syntax to invoke
remote plugins, as the previous plugins alpha is deprecated and going
away on July 10th.
@neoeinstein neoeinstein merged commit 044c92e into neoeinstein:main Jun 30, 2023
@pkwarren pkwarren deleted the pkw/update-buf-remote-plugins-docs branch June 30, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants