Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add enable_type_names #85

Merged
merged 4 commits into from
Feb 15, 2024
Merged

add enable_type_names #85

merged 4 commits into from
Feb 15, 2024

Conversation

Jinwei1987
Copy link
Contributor

update prost and add enable_type_names

@neoeinstein
Copy link
Owner

There seems to be more going on here than just enable_type_names. If you could rebase this and have a PR focused just on enable_type_names, and then I can look at a distinct one on changing output path behavior.

@Jinwei1987
Copy link
Contributor Author

There seems to be more going on here than just enable_type_names. If you could rebase this and have a PR focused just on enable_type_names, and then I can look at a distinct one on changing output path behavior.

I have rebased the code. Right now this pull request only contains enable_type_names features.

@neoeinstein neoeinstein merged commit 4aa6052 into neoeinstein:main Feb 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcus-griep-simplisafe marcus-griep-simplisafe marcus-griep-simplisafe approved these changes

@neoeinstein neoeinstein neoeinstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jinwei1987 @neoeinstein @marcus-griep-simplisafe