Normalize CRLF mod description line endings to use LF instead #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Minecraft can't properly display CRLF line endings in its GUIs. This leads to them being shown as characters in mod descriptions on the NeoForge mod list screen, as described in the following issue
Expected behavior
Line ending characters should not be visible by any means.
The solution
When parsing mod descriptions, we replace all CRLF line endings with LF. By eliminating the root cause of this issue in FML, we ensure CRLFs will not show up anywhere in game, be it the neoforge mod list screen or other mod GUIs.
Fixes neoforged/NeoForge#104