Add support for proper plural translation #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using the ICU plural format. This does not use full Messageformats, just the number part. Embed them with "%()" in the language file, e.g. "dogs": "There %(one{is # dog} other{are # dogs}) here."
See also: https://unicode-org.github.io/icu-docs/apidoc/dev/icu4j/com/ibm/icu/text/PluralFormat.html and https://www.unicode.org/cldr/charts/45/supplemental/language_plural_rules.html
|
which is actually invalid for vanilla and not just ignored
Matyrobbrt
added
1.21
HenryLoenwind
changed the title
TelepathicGrunt
approved these changes
Nov 9, 2024
|
When you can, could you add documentation of this plural translation system to the neo docs? Not sure where in the docs it will fit but would be good to add it so people know the new system exists |
|
🚀 This PR has been released as NeoForge version |
Technici4n
added a commit
that referenced
this pull request
Nov 11, 2024
This reverts commit e7f15f9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the ICU plural format. This does not use full MessageFormats, just the number part in isolation. Embed them with "%()" in the language file, e.g.
"mymod.dogs": "There %n(one{is # dog} other{are # dogs}) here.",This would be equivalent to a message format of"There {0,plural, one{is # dog} other{are # dogs}} here,".See also: https://unicode-org.github.io/icu-docs/apidoc/dev/icu4j/com/ibm/icu/text/PluralFormat.html and https://www.unicode.org/cldr/charts/45/supplemental/language_plural_rules.html