Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.4] Add Datagen Helper for Creating Modded Datapack Registry Objects #1882

Merged

Conversation

ChampionAsh5357
Copy link
Contributor

Adds the helper methods createDatapackRegistryObjects to construct the DatapackBuiltinEntriesProvider. This also changes the output of GatherDataEvent#getLookupProvider to the completable future constructed by the provider, allowing createProvider to be used properly when datapack objects are to be generated and used in other providers.

@ChampionAsh5357 ChampionAsh5357 added data driven This request involves a data driven system 1.21.4 Targeted at Minecraft 1.21.4 labels Jan 20, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 20, 2025

  • Publish PR to GitHub Packages

Last commit published: c890831e4c3546267c44f3ab605c548f9d00edbe.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1882' // https://github.com/neoforged/NeoForge/pull/1882
        url 'https://prmaven.neoforged.net/NeoForge/pr1882'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1882.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1882
cd NeoForge-pr1882
curl -L https://prmaven.neoforged.net/NeoForge/pr1882/net/neoforged/neoforge/21.4.70-beta-pr-1882-feat-datapack-datagen/mdk-pr1882.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@ChampionAsh5357 ChampionAsh5357 merged commit 9eab4c5 into neoforged:1.21.x Jan 25, 2025
7 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.76-beta.

@Matyrobbrt

This comment has been minimized.

neoforged-automation bot pushed a commit that referenced this pull request Jan 26, 2025
@neoforged-automation
Copy link

Created backport PR: #1917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 data driven This request involves a data driven system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants