This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Windows support #42
Merged
Merged
Windows support #42
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c97ef1a
Don't supply a NEON_NODE_ABI env variable
966909b
Supply cargo --target based on npm --arch flag
maxbrunsfeld 158ac12
Generate build.rs that links node.lib on windows
maxbrunsfeld c59d9fd
Supply cargo target based on process.arch on windows
maxbrunsfeld dbb02a2
Update build.rs.hbs
a9ee426
Merge branch 'support-npm-arch-flag' of https://github.com/atom/neon-…
df68f54
make the comment about the ABI environment variable clearer
9ca4ebb
fix whitespace nit in #42 review
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
use std::env; | ||
|
||
fn main() { | ||
if cfg!(windows) { | ||
let debug = env::var("DEBUG").ok().map_or(false, |s| s == "true"); | ||
let configuration = if debug { "Debug" } else { "Release" }; | ||
let node_root_dir = env::var("DEP_NEON_SYS_NODE_ROOT_DIR").unwrap(); | ||
let node_lib_file = env::var("DEP_NEON_SYS_NODE_LIB_FILE").unwrap(); | ||
println!("cargo:rustc-link-search={}\\{}", node_root_dir, configuration); | ||
println!("cargo:rustc-link-lib={}", node_lib_file); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra space makes the
=
not align