chore(neon): fix clippy lints #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dherman
changed the title
kjvalencik
requested changes
Nov 24, 2024
There was a problem hiding this comment.
@dherman, it's awesome to get these fixed! I think a couple of the memory leak releases shouldn't panic.
Maybe a good compromise is to panic in debug mode and ignore in release mode?
Additionally, I haven't traced through, but the return false on any error lines seem incorrect. Those should probably only return false on exception.
dherman
commented
Nov 25, 2024
…view: - style: don't `assert_eq!` of `Ok(())`, just `.unwrap()` - style: capitalize no_panic error message strings - logic: don't unwrap deleting async work if we're about to fail with a more clear error anyway - logic: when returning false to propagate exceptions, only do so on PendingException; panic on other errors
kjvalencik
approved these changes
Nov 26, 2024
|
Awesome changes! 🐛 🪲 🔨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Clippy lints exposed by the awesome refactoring done in #1065.