Workaround for Windows node-gyp bug #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let's just unconditionally downgrade npm to 6.11.3 for now.
|
Ok good, that’s working... now it’s just the compile tests that aren’t. I’ll disable them for now until we have a less fragile way to test compiler error messages. |
rustc tweaks its error message formatting.
kjvalencik
reviewed
Jan 28, 2020
kjvalencik
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See nodejs/node-gyp#1933
This downgrades npm to the last version that didn't have the bug for Windows CI, to avoid hitting the bug. Once the above bug is fixed we can remove this workaround.