Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: module re-organization #20

Merged
merged 10 commits into from
Jul 25, 2018

Conversation

dherman
Copy link
Contributor

@dherman dherman commented Jun 1, 2018

A backwards-incompatible reorganization of the public API organization of neon::* to make it easier and more ergonomic to import Neon APIs.

Rendered

Here's a temporary site where you can browse the API docs.

Copy link

@tptee tptee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only thought: any reason we want to exclude neon::thread from the prelude? Do we consider it advanced enough to bury a little?

Otherwise this is solid!

@dherman
Copy link
Contributor Author

dherman commented Jul 5, 2018

@tptee It just felt like more of a specific use case, and not something you would be likely to want to use in most projects. But we can add it to the prelude compatibly if it becomes clear it's being used most of the time.

@dherman
Copy link
Contributor Author

dherman commented Jul 5, 2018

📢 This RFC is going into final comment period! We will plan to merge it within a week if there aren't significant new issues that arise in the next week. 📢

@dherman dherman added the final comment period last opportunity to discuss the proposed conclusion label Jul 5, 2018
@dherman dherman changed the title RFC: simplified module organization RFC: module re-organization Jul 9, 2018
@dherman dherman merged commit 3daef71 into neon-bindings:master Jul 25, 2018
@dherman dherman deleted the simplified-module-org branch July 25, 2018 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
final comment period last opportunity to discuss the proposed conclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants