Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: error subtyping #23

Merged
merged 2 commits into from
Jul 25, 2018
Merged

RFC: error subtyping #23

merged 2 commits into from
Jul 25, 2018

Conversation

dherman
Copy link
Contributor

@dherman dherman commented Jul 9, 2018 •
edited
Loading

From the RFC summary:

This RFC proposes a backwards-incompatible change to the construction of JsError values. It makes the following changes:

  • Replaces the ErrorKind enum with simple methods for constructing various error types, to make it possible to add new error types compatibly in the future.
  • Reduces the set of error types to Error, RangeError, and TypeError, since these are currently the only error types supported by N-API.

Rendered

@dherman dherman mentioned this pull request Jul 10, 2018
Merged
@dherman
Copy link
Contributor Author

dherman commented Jul 10, 2018

📢 This was a bit of a last-minute addition to #22, but I'm going to put it in final comment period as well. We haven't seen much discussion and I'd like to get the 0.2 release out soon. 📢

@dherman dherman added the final comment period last opportunity to discuss the proposed conclusion label Jul 10, 2018
@dherman dherman merged commit ff7d9f3 into neon-bindings:master Jul 25, 2018
@dherman dherman deleted the error-subtyping branch July 25, 2018 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
final comment period last opportunity to discuss the proposed conclusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dherman