-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vitest #123
Add vitest #123
Conversation
I've added GitHub Actions for a dummy test and also a TypeScript type check. We currently have 3 separate workflows (.yml files) that are mostly the same. We could alternatively have these be three jobs within the same workflow, or even three |
I think a lot of the common setup like install deps should be a single action that we import, something like this: https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/actions/prepare/action.yml Let's forget about this for now 👍 |
.github/workflows/check-types.yml
Outdated
@@ -0,0 +1,16 @@ | |||
name: Check TypeScript types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do both type and format checking in the same workflow, they are usually very coupled with each other - maybe call it lint
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we do to actually update the lockfile since we use bun install
? I don't expect it to update the package-lock.json
I think, AFAIK it only reads it to seed the resolution tree but then keeps using its own binary lockfile thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, after looking at https://bun.sh/docs/cli/install#production-mode it seems --frozen-lockfile
isn't going to do anything for us since we don't include a Bun lockfile (bun.lockb
) in the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Add vitest example test and add GitHub action to run it.
Relatedly, add
.prettierrc
and a GitHub Action to check TypeScript types.