Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement eth_getCode (which currently is hardcoded to return 0x01) #428

Closed
saurik opened this issue Jan 3, 2022 · 0 comments
Closed

implement eth_getCode (which currently is hardcoded to return 0x01) #428

saurik opened this issue Jan 3, 2022 · 0 comments
Assignees
@otselnik
Labels
bug Something isn't working Medium

Comments

@saurik
Copy link

saurik commented Jan 3, 2022 •
edited by sync-by-unito bot
Loading

When I reported this on Telegram (to the "focus group" channel I was asked to join and which I've since escaped) I reported this as being an issue with empty contracts, as I'm used to seeing a similar issue--returning "0x00" instead of "0x"--on new JSON/RPC implementations (at least rsk and Telos that I remember made that mistake). However, reading your code, I see that you've simply not implemented this API. I use this API a lot, so I hope you get around to implementing it before you launch.

https://github.com/neonlabsorg/proxy-model.py/blob/43f6e8bacbcbfadb2ddbefa084350de2364c9a88/proxy/plugin/solana_rest_api.py#L391-L392

┆Issue is synchronized with this Jira Task by Unito
@afalaleev afalaleev added bug Something isn't working High Medium and removed High labels Jan 23, 2022
@otselnik otselnik self-assigned this Jan 24, 2022
otselnik added a commit that referenced this issue Jan 27, 2022
@otselnik
#428 eth_getCode implementation
86675bd
otselnik added a commit that referenced this issue Feb 1, 2022
@otselnik
#428 return code by proxy request
df18dc8
otselnik added a commit that referenced this issue Feb 1, 2022
@otselnik
#428 fix merge errors
b13d84b
otselnik added a commit that referenced this issue Feb 1, 2022
@otselnik
#428 remove debug info
15a6f8a
@otselnik otselnik linked a pull request Feb 1, 2022 that will close this issue
#428 implement eth_getCode #535
Merged
@otselnik otselnik removed a link to a pull request Feb 1, 2022
#428 implement eth_getCode #535
Merged
otselnik added a commit that referenced this issue Feb 1, 2022
@otselnik
#428 remove debug info
b39b9da
otselnik added a commit that referenced this issue Feb 3, 2022
@otselnik
#428 fix PR issues
e0c067b
otselnik added a commit that referenced this issue Feb 3, 2022
@otselnik
#428 add getcode test for resized accounts
9d2e907
otselnik added a commit that referenced this issue Feb 3, 2022
@otselnik
#428 implement eth_getCode (#535)
e5e9649 
* #428 eth_getCode implementation

* #428 return code by proxy request

* #428 fix merge errors

* #428 remove debug info

* #428 remove debug info

* #428 fix PR issues

* #428 add getcode test for resized accounts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otselnik otselnik

Labels
bug Something isn't working Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@saurik @rozhkovdmitrii @otselnik @afalaleev